This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140
Example
When using
S3Bucket.put_directory(ignore_file=".prefectignore")
thefilter_files
function is called which returns theincluded_files
as strings. But the actual files are of typepath.PosixPath
and includes the whole absolute path.As an example:
It tries to find those absolute posix paths in the included files, which does not work and thus skips files which should be uploaded:
Instead I use the relative path and parse it to a string:
Checklist