Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playhead #313

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Add playhead #313

merged 7 commits into from
Nov 6, 2023

Conversation

brandonreid
Copy link
Contributor

@brandonreid brandonreid commented Nov 3, 2023

Playhead ready! There are still issues with running that we'll want to investigate once pending tasks are removed from view:

Screen.Recording.2023-11-03.at.4.10.57.PM.mov

After refresh:
image

@brandonreid brandonreid requested a review from a team as a code owner November 3, 2023 19:12
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for prefect-graphs ready!

Name Link
🔨 Latest commit 7355190
🔍 Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/6548d0e14d21dc00082c1958
😎 Deploy Preview https://deploy-preview-313--prefect-graphs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/factories/playhead.ts Outdated Show resolved Hide resolved
src/factories/playhead.ts Outdated Show resolved Hide resolved
@pleek91
Copy link
Collaborator

pleek91 commented Nov 5, 2023

@brandonreid pushed a commit to simplify this a bit. Double check that this still functions as it should. From my testing it works the same.

@brandonreid
Copy link
Contributor Author

@brandonreid pushed a commit to simplify this a bit. Double check that this still functions as it should. From my testing it works the same.

LGTM! Tried it out, functions well. Nice cleanup!

@pleek91 pleek91 merged commit f8a9c38 into main Nov 6, 2023
@pleek91 pleek91 deleted the playhead branch November 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants