Sync global scales when scale changes #288

pleek91 · 2023-10-30T19:25:55Z

Description

Fixes a bug where the viewport's visible date range would not reflect changes to the horizontal scale

Updates NodesContainerFactory to emit a fetched event with the RunGraphData
Updates objects/nodes.ts to listen for the fetched event and use that for its run data
Update the global horizontal scale when the horizontal layout scale changes
Update the viewport's visible date range when the global horizontal scale changes

…ings

…e with the scales

netlify · 2023-10-30T19:26:00Z

Name	Link
🔨 Latest commit	`144b017`
🔍 Latest deploy log	https://app.netlify.com/sites/prefect-graphs/deploys/654003456454b70008d809c3
😎 Deploy Preview	https://deploy-preview-288--prefect-graphs.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pleek91 added 7 commits October 30, 2023 11:45

Rename layout object to settings and always get column size from sett…

01f3a22

…ings

More accurate name since scale is only for the horizontal axis

a783614

Fix label positioning for flow run labels

0e85a72

Finally rename nodeMargin to nodePadding

506d712

Fix the label position for a flow run again

a68f970

Add some basic ux for changing the horizontal scale

019d90b

Create scales from the root node data and sync the viewport date rang…

144b017

…e with the scales

pleek91 requested a review from a team as a code owner October 30, 2023 19:25

znicholasbrown approved these changes Oct 30, 2023

View reviewed changes

pleek91 merged commit 0833123 into main Oct 30, 2023
4 checks passed

pleek91 deleted the update-viewport-date-range-when-scale-changes branch October 30, 2023 20:19