Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borders to sub nodes #276

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Add borders to sub nodes #276

merged 4 commits into from
Oct 26, 2023

Conversation

pleek91
Copy link
Collaborator

@pleek91 pleek91 commented Oct 26, 2023

Description

Before
image
image

After
image
image

@pleek91 pleek91 requested a review from a team as a code owner October 26, 2023 21:15
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for prefect-graphs ready!

Name Link
🔨 Latest commit ef7d900
🔍 Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/653ad8e140169d0008ad9b03
😎 Deploy Preview https://deploy-preview-276--prefect-graphs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file fix an issue where if the width/height of the border was smaller than the radius the sprites would overlap. This makes sure the radius is not larger than the width/height.

Copy link
Contributor

@brandonreid brandonreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit here but g2g

@pleek91 pleek91 merged commit dd7b426 into main Oct 26, 2023
4 checks passed
@pleek91 pleek91 deleted the sub-nodes-border branch October 26, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants