Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set the view to trace or dependency #253

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

pleek91
Copy link
Collaborator

@pleek91 pleek91 commented Oct 19, 2023

Description

Adds the graph settings to the graph actions. This currently has two settings. Only view is supported at this point.

  • View - How nodes are rendered along the x axis
    • Dependency - All nodes are the same size and ordered by how far from the "root" of the graph they are
    • Trace - Nodes are rendered according to run time
  • Layout - How nodes are rendered along the y axis
    • Waterfall - Fastest layout which renders nodes along the y axis in order of when they occurred (first nodes at the top, last at the bottom)
    • Nearest Parent - Slower layout which aims to render nodes more logically based on where a nodes parent nodes are located.
image image

@pleek91 pleek91 requested a review from a team as a code owner October 19, 2023 17:17
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for prefect-graphs ready!

Name Link
🔨 Latest commit 06bb9ed
🔍 Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/65317e96bd3fe60008c14910
😎 Deploy Preview https://deploy-preview-253--prefect-graphs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

</template>

<p-overflow-menu class="run-graph-settings__menu">
<p-label label="View">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nbd for now, but I do feel this distinction is tough to groc. The x access can be time bound or like.. "linear"? then the y axis or sorting can be arranged differently. Probably just semantics, maybe a simple flat list of layouts is better, not totally sure off the cuff.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah idk here. Technically the "view" is how the x axis is rendered and the "layout" is how the y axis is rendered. And it makes sense to mix and match both. But I'm also not 100% on this UX for controlling it. Important part is we can control it haha.

@pleek91 pleek91 merged commit fbae4d9 into main Oct 19, 2023
4 checks passed
@pleek91 pleek91 deleted the horizontal-waterfall-layouts branch October 19, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants