Render sub flow runs #252
Merged
Render sub flow runs #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-graphs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
commented
Oct 18, 2023
pleek91
commented
Oct 18, 2023
| @@ -50,6 +74,7 @@ export async function flowRunContainerFactory() { | |||
| } | |||
|
|
|||
| return { | |||
| kind: 'flow-run' as const, | |||
There was a problem hiding this comment.
Added kind as a a discriminating union for the nodeContainerFactory
pleek91
commented
Oct 18, 2023
Comment on lines
-16
to
-18
| type Events = { | ||
| rendered: void, | ||
| } |
There was a problem hiding this comment.
I removed the factory specific events in favor of augmenting the built in pixi events. That way I can emit directly on containers which is simpler and avoids some event bubbling.
pleek91
commented
Oct 18, 2023
|
|
||
| return Math.max(...values.values(), 0) | ||
| return Math.max(...values.values(), config.styles.nodeHeight) |
There was a problem hiding this comment.
This is evolving a bit to factor in the entire row height and not just the "offset" the name of this utility is likely to change to reflect but waiting to see how this shakes out
pleek91
commented
Oct 18, 2023
Comment on lines
+41
to
+47
| function toggle(): void { | ||
| open = !open | ||
|
|
||
| if (open) { | ||
| renderNodes() | ||
| } | ||
| } |
There was a problem hiding this comment.
This will evolve quite a bit. Just a POC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clicking on a flow run on the graph will the flow run on the graph. Bumping other content out of the way.
For now it just renders right on to of the flow run that was clicked on and you cannot collapse it.
WIP PR to try and keep things a little smaller.
The last node in the demo is a flow run. Clicking on it will render another demo flow on the graph.