Add new models #209
Merged
Add new models #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-graphs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
commented
Sep 27, 2023
| defineProps<{ | ||
| flowRunId: string, | ||
| config: FlowRunGraphConfig, |
There was a problem hiding this comment.
This is noteworthy to call out. By accepting the flowRunId and a fetch method to get the graph data. This component can do its own fetching and refreshing of data. Which means it can fetch its own sub flow data rather than depending on the implementation to listen for events.
I'm not sure how this will effect the implementation forcing an update. Might expose a refresh method on the component instance itself.
There was a problem hiding this comment.
Ah I dig this! The model binding hurdles were def a bit much there.
brandonreid
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds models to match the new endpoint being built.