Skip to content

Commit

Permalink
feat(General.json): add more strings and make strings consistent acro…
Browse files Browse the repository at this point in the history
…ss activities (#9291)

* feat(General.json): add more strings and make strings consistent across general.json & activities

feat: test

feat: test

chore(General.json): sort file

* chore(General.json): format using eslint

* Apply suggestions from code review

Signed-off-by: github plz bring back DarkVIllager <[email protected]>

* Update websites/E/Eurogamer/metadata.json

Signed-off-by: github plz bring back DarkVIllager <[email protected]>

* fix(Pokeflix): fix issues

---------

Signed-off-by: github plz bring back DarkVIllager <[email protected]>
  • Loading branch information
darkvillager2 authored Mar 3, 2025
1 parent 390b640 commit 498d6c9
Show file tree
Hide file tree
Showing 34 changed files with 176 additions and 148 deletions.
10 changes: 5 additions & 5 deletions websites/0-9/7tv/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ async function getStrings() {
return presence.getStrings(
{
viewHome: 'general.viewHome',
viewing: 'general.viewing',
view: 'general.view',
search: 'general.search',
searchFor: 'general.searchFor',
store: 'general.store',
Expand Down Expand Up @@ -91,7 +91,7 @@ presence.on('UpdateData', async () => {
presenceData.details = strings.viewPage
presenceData.state = textContent('.emote-name p')
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view

if (showEmotes) {
presenceData.largeImageKey = getImage(
Expand All @@ -110,7 +110,7 @@ presence.on('UpdateData', async () => {
presenceData.details = privacy ? strings.viewAnUser : strings.viewProfile
presenceData.state = textContent('.user-card .username')
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view

if (!privacy) {
presenceData.largeImageKey = getImage('.user-card .user-picture-wrapper img') ?? ActivityAssets.Logo
Expand All @@ -122,7 +122,7 @@ presence.on('UpdateData', async () => {
presenceData.details = strings.viewList
presenceData.state = textContent('.emote-set-wrapper > div > div > h3')
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view
break

case 'inbox':
Expand All @@ -135,7 +135,7 @@ presence.on('UpdateData', async () => {
presenceData.details = strings.viewPage
presenceData.state = strings.store
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view
break

case 'legal':
Expand Down
4 changes: 2 additions & 2 deletions websites/A/Apple/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ async function getStrings() {
{
viewHome: 'general.viewHome',
viewProduct: 'general.viewProduct',
viewing: 'general.viewing',
view: 'general.view',
viewProfile: 'general.viewProfile',
readingArticle: 'general.readingArticle',
comparing: 'apple.comparing',
Expand Down Expand Up @@ -352,7 +352,7 @@ presence.on('UpdateData', async () => {
'h1.typography-hero-eyebrow.hero-eyebrow.hero-copy-item',
)

presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = OS?.textContent || 'Unknown'

if (buttons && OS) {
Expand Down
4 changes: 2 additions & 2 deletions websites/A/animepahe/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ async function getStrings() {
episode: 'general.episode',
watching: 'general.watching',
watchingMovie: 'general.watchingMovie',
viewing: 'general.viewing',
view: 'general.view',
viewGenre: 'general.viewGenre',
viewCategory: 'general.viewCategory',
viewPage: 'general.viewPage',
Expand Down Expand Up @@ -193,7 +193,7 @@ presence.on('UpdateData', async () => {
strings = await getStrings()
}

const viewing = strings.viewing.slice(0, -1)
const viewing = strings.view.slice(0, -1)

switch (path[0]) {
// homepage / browsing new releases
Expand Down
2 changes: 1 addition & 1 deletion websites/D/Discord/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"url": "discord.com",
"regExp": "([a-z0-9-]+[.])*(discord[.]com|discord[.]gg|discordapp[.]com|discordmerch[.]com|discordstatus[.]com)[/]",
"version": "3.0.37",
"version": "3.0.38",
"logo": "https://cdn.rcd.gg/PreMiD/websites/D/Discord/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/D/Discord/assets/thumbnail.png",
"color": "#7289DA",
Expand Down
8 changes: 4 additions & 4 deletions websites/D/Discord/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async function getStrings() {
serversEdit: 'discord.devs.serversEdit',
docs: 'discord.devs.docs',
status: 'discord.status',
viewing: 'general.viewing',
view: 'general.view',
uptime: 'general.uptimeHistory',
incident: 'general.incidentHistory',
viewAnIncident: 'general.viewAnIncident',
Expand Down Expand Up @@ -532,11 +532,11 @@ presence.on('UpdateData', async () => {
},
'/uptime/': {
details: strings.status,
state: `${strings.viewing} ${strings.uptime}`,
state: `${strings.view} ${strings.uptime}`,
},
'/history/': {
details: strings.status,
state: `${strings.viewing} ${strings.incident}`,
state: `${strings.view} ${strings.incident}`,
},
'/incidents/': {
details: strings.status,
Expand Down Expand Up @@ -723,7 +723,7 @@ presence.on('UpdateData', async () => {
},
'/cart/': {
details: strings.merch,
state: `${strings.viewing} ${strings.shopCart}`,
state: `${strings.view} ${strings.shopCart}`,
},
'/search/': {
details: strings.merch,
Expand Down
2 changes: 1 addition & 1 deletion websites/E/Eurogamer/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"www.eurogamer.nl",
"www.eurogamer.pl"
],
"version": "1.0.3",
"version": "1.0.4",
"logo": "https://cdn.rcd.gg/PreMiD/websites/E/Eurogamer/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/E/Eurogamer/assets/thumbnail.png",
"color": "#007cbf",
Expand Down
6 changes: 3 additions & 3 deletions websites/E/Eurogamer/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ async function getStrings() {
viewList: 'general.viewList',
viewMovie: 'general.viewMovie',
viewGenre: 'general.viewGenre',
viewing: 'general.viewing',
view: 'general.view',
viewCategory: 'general.viewCategory',
support: 'general.support',
viewProfile: 'general.viewProfile',
Expand Down Expand Up @@ -124,15 +124,15 @@ presence.on('UpdateData', async () => {
break
}
case 'subscribe': {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = strings.support
break
}
case 'code-of-conduct':
case 'editorial-policy':
case 'review-policy':
case 'terms-and-conditions': {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = document.querySelector('.section_title')
break
}
Expand Down
2 changes: 1 addition & 1 deletion websites/G/Google Docs/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"url": "docs.google.com",
"regExp": "docs[.]google([.][a-z]+)+[/]",
"version": "1.4.33",
"version": "1.4.34",
"logo": "https://cdn.rcd.gg/PreMiD/websites/G/Google%20Docs/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/G/Google%20Docs/assets/thumbnail.jpg",
"color": "#3a404a",
Expand Down
20 changes: 10 additions & 10 deletions websites/H/Habr/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ async function getStrings() {
searchFor: 'general.searchFor',
searchSomething: 'general.searchSomething',
viewHome: 'general.viewHome',
viewing: 'general.viewing',
view: 'general.view',
viewPage: 'general.viewPage',
},
await presence.getSetting<string>('lang').catch(() => 'ru'),
Expand Down Expand Up @@ -63,14 +63,14 @@ presence.on('UpdateData', async () => {
case 'feed':
presenceData.details = privacy
? strings.viewHome
: `${strings.viewing} ${strings.chapter.toLowerCase()} ${textContent(
: `${strings.view} ${strings.chapter.toLowerCase()} ${textContent(
'.tm-section-name__text',
)}`
presenceData.state = document.querySelector(
'.tm-tabs__tab-link_active',
)?.firstChild?.textContent
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view

if (path[3] === 't') {
presenceData.details = strings.reading
Expand All @@ -92,14 +92,14 @@ presence.on('UpdateData', async () => {
case 'users':
presenceData.details = privacy
? strings.viewHome
: `${strings.viewing} ${strings.chapter.toLowerCase()} ${textContent(
: `${strings.view} ${strings.chapter.toLowerCase()} ${textContent(
'.tm-section-name__text',
)}`
presenceData.state = document.querySelector(
'.tm-tabs__tab-link_active',
)?.firstChild?.textContent
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view

if (path[3]) {
presenceData.details = `${strings.viewPage} ${
Expand All @@ -121,22 +121,22 @@ presence.on('UpdateData', async () => {
break

case 'auth':
presenceData.details = `${strings.viewing} ${textContent(
presenceData.details = `${strings.view} ${textContent(
'.tm-section-name__text',
)}`
presenceData.state = textContent('.tm-tabs__tab-link_active')
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view
break

case 'hub':
presenceData.details = `${strings.viewing} хаб`
presenceData.details = `${strings.view} хаб`
presenceData.state = textContent('.tm-hub-card__name span')
presenceData.largeImageKey = document.querySelector<HTMLImageElement>(
'.tm-entity-image__pic',
)?.src
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view
break

case 'company':
Expand All @@ -150,7 +150,7 @@ presence.on('UpdateData', async () => {
'.tm-company-card__header .tm-entity-image__pic',
)?.src
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view
presenceData.buttons = [
{
label: strings.buttonViewPage,
Expand Down
2 changes: 1 addition & 1 deletion websites/H/Hoyolab/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"url": "www.hoyolab.com",
"regExp": "([a-z0-9-]+[.])*hoyolab[.]com[/]",
"version": "1.1.11",
"version": "1.1.12",
"logo": "https://cdn.rcd.gg/PreMiD/websites/H/Hoyolab/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/H/Hoyolab/assets/thumbnail.png",
"color": "#657ef8",
Expand Down
6 changes: 3 additions & 3 deletions websites/H/Hoyolab/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ async function getStrings() {
return presence.getStrings(
{
readingArticle: 'general.readingArticle',
viewing: 'general.viewing',
view: 'general.view',
viewingList: 'general.viewList',
viewingUser: 'general.viewUser',
viewingHomepage: 'general.viewHome',
Expand Down Expand Up @@ -86,7 +86,7 @@ presence.on('UpdateData', async () => {
presenceData.details = `${strings.viewingHomepage}`
}
else {
presenceData.details = `${strings.viewing} ${
presenceData.details = `${strings.view} ${
homepageName[pathList[1]]
}`
}
Expand Down Expand Up @@ -118,7 +118,7 @@ presence.on('UpdateData', async () => {
break
}
case 'setting': {
presenceData.details = `${strings.viewing} Account settings`
presenceData.details = `${strings.view} Account settings`
break
}
case 'search': {
Expand Down
2 changes: 1 addition & 1 deletion websites/K/KickAssAnime/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"kickassanime.ro"
],
"regExp": "(([a-z0-9-]+[.])*kickassanime([.][a-z]+)+)|(kaas[.].*)|((www[0-9]*[.])?(kickassanime[.][a-z]+))",
"version": "1.2.8",
"version": "1.2.9",
"logo": "https://cdn.rcd.gg/PreMiD/websites/K/KickAssAnime/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/K/KickAssAnime/assets/thumbnail.png",
"color": "#c7c95b",
Expand Down
12 changes: 6 additions & 6 deletions websites/K/KickAssAnime/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ async function getStrings() {
viewSeries: 'general.buttonViewSeries',
viewMovie: 'general.buttonViewMovie',
watchEpisode: 'general.buttonViewEpisode',
viewing: 'general.viewing',
view: 'general.view',
searching: 'general.searchFor',
episode: 'general.episode',
browse: 'general.browsing',
Expand Down Expand Up @@ -115,27 +115,27 @@ presence.on('UpdateData', async () => {
break
}
case pathname.includes('schedule'): {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = 'The schedule'
break
}
case pathname.includes('recent'): {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = 'Recently added anime'
break
}
case pathname.includes('popular'): {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = 'Popular anime'
break
}
case pathname.includes('anime'): {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = 'All anime'
break
}
case pathname.includes('trending'): {
presenceData.details = strings.viewing
presenceData.details = strings.view
presenceData.state = 'Trending anime'
break
}
Expand Down
4 changes: 2 additions & 2 deletions websites/M/MangaKatana/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ async function getStrings() {
search: 'general.search',
searchFor: 'general.searchFor',
searchSomething: 'general.searchSomething',
viewing: 'general.viewing',
view: 'general.view',
viewHome: 'general.viewHome',
viewPage: 'general.viewPage',
buttonViewPage: 'general.buttonViewPage',
Expand Down Expand Up @@ -136,7 +136,7 @@ presence.on('UpdateData', async () => {
'#single_book .cover img',
)?.src
presenceData.smallImageKey = Assets.Viewing
presenceData.smallImageText = strings.viewing
presenceData.smallImageText = strings.view
presenceData.buttons = [
{
label: strings.buttonViewPage,
Expand Down
4 changes: 2 additions & 2 deletions websites/N/NameMC/presence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ async function getStrings() {
viewSkins: 'namemc.viewSkins',
viewEmoji: 'namemc.viewEmojis',
viewProfile: 'general.viewProfile',
viewing: 'general.viewing',
view: 'general.view',
privacy: 'general.privacy',
search: 'general.searchFor',
buttonViewServer: 'namemc.buttonViewServer',
Expand Down Expand Up @@ -145,7 +145,7 @@ presence.on('UpdateData', async () => {
],
},
'/privacy/': {
details: strings.viewing,
details: strings.view,
state: strings.privacy,
},
'/search': {
Expand Down
Loading

0 comments on commit 498d6c9

Please sign in to comment.