Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TOML #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support TOML #1

wants to merge 1 commit into from

Conversation

PrajwalM2212
Copy link
Owner

No description provided.

@PrajwalM2212 PrajwalM2212 force-pushed the toml branch 4 times, most recently from 7b798e7 to 87e3f6d Compare July 15, 2019 18:02
@PrajwalM2212 PrajwalM2212 changed the title toml mode Support TOML Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
Repository owner deleted a comment from TravisBuddy Jul 15, 2019
@PrajwalM2212
Copy link
Owner Author

@jayvdb @RaiVaibhav @Nosferatul @ksdme @margobra8 Can you review this PR ?

@mooncos
Copy link

mooncos commented Jul 18, 2019

unit tests are passing but moban checks exit with code 1. Review jinja2 sintax and moban_check.sh output

@PrajwalM2212 PrajwalM2212 force-pushed the toml branch 2 times, most recently from 87d0a2e to 9ad124f Compare July 18, 2019 10:56
Repository owner deleted a comment from TravisBuddy Jul 18, 2019
Repository owner deleted a comment from TravisBuddy Jul 18, 2019
Repository owner deleted a comment from TravisBuddy Jul 18, 2019
Repository owner deleted a comment from TravisBuddy Jul 18, 2019
Repository owner deleted a comment from TravisBuddy Jul 18, 2019
@PrajwalM2212 PrajwalM2212 force-pushed the toml branch 2 times, most recently from 15f5822 to f50513a Compare July 18, 2019 12:36
mooncos
mooncos approved these changes Jul 19, 2019
View reviewed changes
Copy link

@mooncos mooncos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Repository owner deleted a comment from TravisBuddy Jul 20, 2019
@PrajwalM2212 PrajwalM2212 force-pushed the toml branch 3 times, most recently from 38199cc to 818c305 Compare July 24, 2019 14:12
Repository owner deleted a comment from TravisBuddy Jul 24, 2019
Repository owner deleted a comment from TravisBuddy Jul 24, 2019
@PrajwalM2212 PrajwalM2212 force-pushed the toml branch 3 times, most recently from 2d45707 to 280acb1 Compare July 24, 2019 16:09
Repository owner deleted a comment from TravisBuddy Jul 24, 2019
Repository owner deleted a comment from TravisBuddy Jul 24, 2019
@PrajwalM2212 PrajwalM2212 mentioned this pull request Jul 24, 2019
Open
@TravisBuddy
Copy link

Hey @PrajwalM2212,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0cee6190-b87e-11e9-af6e-3b363318fc0d

@TravisBuddy
Copy link

Hey @PrajwalM2212,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1c45dc00-c2aa-11e9-86a4-77838e0d0b7a

@PrajwalM2212
Generate config files in TOML
06ebf38 
This PR provides coala-quickstart
the flexibity to generate configuration
files in TOML

Closes coala#336
@TravisBuddy
Copy link

Hey @PrajwalM2212,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4ae9f4f0-c2b0-11e9-86a4-77838e0d0b7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooncos mooncos mooncos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrajwalM2212 @mooncos @TravisBuddy