Fix issue with seamless iframe support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikaleslie
force-pushed
the
iframeFix
branch
from
b2416c4 to
9ab29a6
Compare
erikaleslie
changed the title
Updated code for supporting seamless iframes to check if the iframe is actually seamless before applying the logic. When the iframe is not seamless, the logic should be the same as when the page is not in an iframe at all. These changes assume that seamless iframes will have scrolling="no" or the HTML5 seamless attribute.
erikaleslie
force-pushed
the
iframeFix
branch
from
9ab29a6 to
1b1b3f1
Compare
jeremyabbott
added a commit
that referenced
this pull request
Jan 15, 2016
Fix issue with seamless iframe support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code for supporting seamless iframes to check if the iframe is
actually seamless before applying the logic. When the iframe is not
seamless, the logic should be the same as when the page is not in an
iframe at all.
These changes assume that seamless iframes will have scrolling="no" or
the HTML5 seamless attribute.
I also fixed some of the tabs and spaces in the file.