Do not ignore custom JWT lifetime when using TokenCredentials #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Pr0Ger : is this pull request reasonable? If so, could it be merged to master? If not, I'm ready to amend it as you see fit. While I'm it, are you planning a new release with this and other recent bug fixes? That would be great, thank you. :) |
Pr0Ger
approved these changes
Nov 5, 2020
|
Hi! Thanks for contribution, I can't remember why I didn't merge it earlier Yeah, I'll probably release small release with recent bugfixes and small changes soon and then finally address #74 in another release |
|
Thanks a lot (for this, and for open sourcing PyAPNs2 in the first place). :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure that using a fixture in that case is a good idea, because the relevant argument for the test function (the lifetime) is then far from its use. But I did not want to rewrite all the file either.