This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Use color names, plus fixes #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Artistan
commented
Nov 25, 2017
Artistan
commented
- fix for packageName truncated by POWERLEVEL9K_DIR_OMIT_FIRST_CHARACTER
- processing the pwd/HOME replacement ONCE.
- fix tests for named colors
- use color names by default to allow dark/light themes to adjust colors based on names
|
@dritter - This has a couple fixes for package names and iterm2 colors. |
|
@Artistan - Wow! This is a fantastic PR! It makes a very real improvement to P9k's handling of colors, and fixes a few other issues along the way, too. Thanks so much for not only putting the time into getting this done, but upstreaming it! It's significant enough of a change that I'm going to merge it into Thanks so much, again, for this PR! Welcome to P9k |
Closed
dritter
added a commit
to dritter/powerlevel9k
that referenced
this pull request
Jun 6, 2018
Conflicts were: - README.md: Two commits targeted the brightness table. Powerlevel9k#781 from 14. April 2018 on master and Powerlevel9k#684 from 05. December 2017 on next. - powerlevel9k.zsh-theme: Two commits targeted the rbenv segment. Both achieve the same thing: To show the Ruby version number always. Powerlevel9k#795 on next from 14. April 2018 and Powerlevel9k#610 on master from 28. September 2017. I went with Powerlevel9k#795 here as this - although being newer - is the one on master, and that should be more stable.
dritter
added a commit
to dritter/powerlevel9k
that referenced
this pull request
Jun 6, 2018
Conflicts were: - README.md: Two commits targeted the brightness table. Powerlevel9k#781 from 14. April 2018 on master and Powerlevel9k#684 from 05. December 2017 on next. - powerlevel9k.zsh-theme: Two commits targeted the rbenv segment. Both achieve the same thing: To show the Ruby version number always. Powerlevel9k#795 on next from 14. April 2018 and Powerlevel9k#610 on master from 28. September 2017. I went with Powerlevel9k#795 here as this - although being newer - is the one on master, and that should be more stable.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.