Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PSES's PowerShell session inside of the integrated terminal #293

Closed
daviwil opened this issue Sep 12, 2016 · 1 comment
Closed

Run PSES's PowerShell session inside of the integrated terminal #293

daviwil opened this issue Sep 12, 2016 · 1 comment
Labels
Issue-Enhancement A feature request (enhancement).
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Sep 12, 2016

Recent improvements to VS Code's APIs, specifically the new createTerminal API, have made it possible for our extension to programmatically launch PowerShell inside of the integrated terminal UI. This will allow the user to directly interact with the PowerShell session in which PSES is running for a complete integrated console experience that works even while debugging a script.

Things to consider

  • Might need to work around the issues with passing terminal arguments on Windows by dynamically generating a .bat file: Integrated terminal: Shell args not honored on Windows microsoft/vscode#8429 (comment)
  • Is there a setting to never show the debug console since we don't need it anymore?
  • PSReadline will need to be disabled initially so that the Runspace will be available for command execution when the user isn't typing commands. @lzybkr and I have discussed a way to make this work while PSReadline is active but it will require some extra intelligence in PowerShell Editor Services, so I might put that off for a release.
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Sep 12, 2016
@daviwil daviwil added this to the 0.8.0 milestone Sep 12, 2016
@daviwil daviwil modified the milestones: Backlog, 0.8.0 Nov 29, 2016
@daviwil daviwil modified the milestones: 0.10.0, Backlog Mar 14, 2017
daviwil added a commit that referenced this issue Mar 14, 2017
This change introduces a new terminal-based interactive console experience
in the PowerShell extension.  PowerShell Editor Services is now launched
through VS Code's interactive terminal UI so that it can serve REPL I/O
directly to the user.

This change also modifies the debugger integration such that the same
integrated terminal session is also used during script debugging.

Resolves #293.
daviwil added a commit that referenced this issue Mar 14, 2017
This change introduces a new terminal-based interactive console experience
in the PowerShell extension.  PowerShell Editor Services is now launched
through VS Code's interactive terminal UI so that it can serve REPL I/O
directly to the user.

This change also modifies the debugger integration such that the same
integrated terminal session is also used during script debugging.

Resolves #293.
@hash
Copy link

hash commented Apr 21, 2017

Just my 3 cents, what was wrong with the Debug Console?
Now this extension works differently to others that use Debug Console.
Also something like this returns different results every debug run:
$a
if ($a -lt 1) {
$a = 1
}
$a += 1
$a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

2 participants