Telemetry #529
Telemetry #529
Conversation
|
This commit hardcodes the SDK version. I believe that should be set in paths.targets instead. Or, alternatively, one could consider removing references to $WindowsSDKVersion and switch to using "10.0" which I believe uses the latest 10.0 version installed on the system. |
|
That telemetry will be optional or obligated to all users? |
The telemetry will be optional. The telemetry code will only be enabled for OpenSSH versions that are released with Windows. Users have the option to configure their telemetry preference in Settings. In Windows 10, it's under Privacy-->Diagnostic & Usage Data. OpenSSH telemetry will only send when diagnostic & usage data is set to "optional" (previously known as full). OpenSSH versions released to GitHub will not have the telemetry code enabled. |
contrib/win32/openssh/telemetry.c
Outdated
| free(auth_buffer); | ||
| } | ||
|
|
||
| void send_startup_telemetry(const char* ssh_version, const char* peer_version, |
There was a problem hiding this comment.
Rename it to send_ssh_version_telemetry
There was a problem hiding this comment.
This is a common code for both client and server. See if you can add it's coming from client or server
contrib/win32/openssh/sshTelemetry.c
Outdated
| "SSHD", | ||
| TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage), | ||
| TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES), | ||
| TraceLoggingInt32Array(ports, num_ports, "Port"), |
There was a problem hiding this comment.
We don't need to capture the port numbers.. We want to know if the customer is using default port (22) or custom port
There was a problem hiding this comment.
Oh, I see. I removed the configured ports array from the sshd event, and instead send the port number from the ssh connection event. Is sending the port number sufficient, or do we want to explicitly send "default" or "custom"?
PowerShell/Win32-OpenSSH#1907
Note:
OpenSSH versions released to GitHub will not have the telemetry sent to Microsoft.