Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of 1211 and 1082 #349

Merged
merged 36 commits into from
Nov 5, 2018
Merged

Fix of 1211 and 1082 #349

Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8a9bdd1
Fix of 1211 and 1082
bingbing8 Oct 12, 2018
a6d23b7
add quotes for the cmd only when module path is added.
bingbing8 Oct 15, 2018
8fdf9cc
fix the cmd when it already surrounded by quotes
bingbing8 Oct 16, 2018
e49c002
don't escape command for cmd.exe and shellhost.exe
bingbing8 Oct 16, 2018
09ccbbd
minor updates
bingbing8 Oct 16, 2018
6c5b07d
CreateProcess does not support app surrounded by single quotes.
bingbing8 Oct 16, 2018
0bfc520
added tests for double quotes escaping
bingbing8 Oct 17, 2018
164540d
update tests
bingbing8 Oct 17, 2018
d0f29c7
remove unused var
bingbing8 Oct 18, 2018
12a10da
minor changes
bingbing8 Oct 18, 2018
aa8359e
PAL of do_exec_* APIs
bingbing8 Oct 19, 2018
4ca8dd8
1. change file names
bingbing8 Oct 22, 2018
a387bb5
fix file name
bingbing8 Oct 22, 2018
132eb61
Merge branch 'latestw_all' of https://github.com/powershell/openssh-p…
bingbing8 Oct 25, 2018
c0b39e9
only escape double quotes and backslash for powershell, bash, and cygwin
bingbing8 Oct 26, 2018
aade195
no -c or /c for shells other than cmd, ps, bash, and cygwin
bingbing8 Oct 26, 2018
5c39e8c
add -c for ssh-shellhost
bingbing8 Oct 26, 2018
b52fdb1
minor update
bingbing8 Oct 26, 2018
a0b05e8
update comments
bingbing8 Oct 26, 2018
946af56
update comments
bingbing8 Oct 26, 2018
5ccb3aa
test updates
bingbing8 Oct 26, 2018
ce136df
print out the file for test investigation
bingbing8 Oct 26, 2018
79e19f3
Caller of posix_spawn_internal determine if escaping needed.
bingbing8 Oct 30, 2018
d4677c2
define shell types
bingbing8 Oct 30, 2018
e3cabb7
1. separate cmdline building log from posix_spawn
bingbing8 Oct 31, 2018
0a67c4c
add unit tests for build_exec_command and build_commandline_string
bingbing8 Oct 31, 2018
2300ac5
merge conflicts
bingbing8 Oct 31, 2018
03aea16
revert the comment of one test
bingbing8 Oct 31, 2018
fb33b53
Always add quotes if they are not already there for executables unles…
bingbing8 Nov 2, 2018
8a167e8
check failover condition in posix_spawn
bingbing8 Nov 2, 2018
5da3925
Fix the case when the path has quotes and and add_module_path
bingbing8 Nov 3, 2018
c4bb578
change line ending
bingbing8 Nov 3, 2018
641421b
changed encoding
bingbing8 Nov 3, 2018
127f2fe
update line ending and encoding
bingbing8 Nov 3, 2018
0c91470
revert the new line in sshd.vcproj.filters
bingbing8 Nov 3, 2018
aa0e165
minor update for format
bingbing8 Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
945 changes: 473 additions & 472 deletions contrib/win32/openssh/sshd.vcxproj
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion contrib/win32/openssh/sshd.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,16 @@
<ClCompile Include="$(OpenSSH-Src-Path)contrib\win32\win32compat\spawn-ext.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="$(OpenSSH-Src-Path)contrib\win32\win32compat\win32_groupaccess.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="$(OpenSSH-Src-Path)contrib\win32\win32compat\w32-doexec.c">
<Filter>Source Files</Filter>
</ClCompile>
</ItemGroup>
<ItemGroup>
<ResourceCompile Include="version.rc">
<Filter>Resource Files</Filter>
</ResourceCompile>
</ItemGroup>
</Project>
</Project>
Loading