Ported bash based E2E tests #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge changes for 7.7.1.1 Includes: 1. [Update code to dynamic load Lsa functions until RS5 SDK includes them](https://microsoft.visualstudio.com/OS/_workitems/edit/17828222) 2. [Add conpty support in openssh](https://microsoft.visualstudio.com/OS/_workitems/edit/17828259)
sync up with latest RS5 source
Fixed following issues: 1) Wierd characters (?25l) are seen, when logged in from ssh client 2) Backspace doesn't work in powershell window
Added support to have ssh-shellhost work as a standby shell (ssh-shellhost -c "cmdline") simply executes cmdline via CreateProcess Added E2E test cases and fixed unittests broken from prior changes
Following changes are imported from GitHib - Optimized group membership resolution - Cleanup SeServiceLogonRight For Restricted User Account - Fix Command Prompt For Usernames With '$' In Them
Added PTY launch interface that supports both conpty and ssh-shellhost pty. Implemented PTY control channel in ssh-shellhost that supports Window resize events.
This enables ssh and ssh-keygen functionality around updating known_hosts
…explicit command Issue is due to missing quotes around cmd.exe commandline Also includes the following changes: - Re-enabled conpty that was accidentally disabled during previous pty refactoring changes - modified ssh-shellhost pty argument to ---pty to remove ambiguity in cases when both -p and -c are present in commandline. Ex. ssh-shellhost.exe -c "myprogram -p -c argument"
add pinvoke of LsaRemoveAccountRights
…dress VS warnings. Includes: - Fix descriptor leaks in win32 fstat implementation: PowerShell/Win32-OpenSSH#1209 - Modified user principal name lookup to default to the implicit form (SamAccountName@DnsDomainName) if no explicit user principal name attribute is found on the account: PowerShell/Win32-OpenSSH#1213
Fix IOT issue while expanding __PROGRAMDATA__
1) Fix CTRL+C- https://microsoft.visualstudio.com/OS/_workitems/edit/18523925 2) Use XTERMVTSeq for F1,F2,F3,F4. https://microsoft.visualstudio.com/OS/_workitems/edit/18523906
… sshd_config has Match block https://microsoft.visualstudio.com/OS/_workitems/edit/18512320 1) When LSA auth is configured and sshd_config has Match block then ga_init() is doing fatal(). If customLSAAuth is enabled - return 0 instead of fatal(). This is a temporary fix to allow our internal partners to change their scripts. 2) bash_script_iteration changes - For the SKUs where we have openssh installed in c:\windows\system32\openssh, we don't need to call install-sshd.ps1, uninstall-sshd.ps1. Added a new script parameter to skip this functionality.
…as artifacts. Update vsts scripts to update unittest test binaries as artifacts.
Skip backslash escaping when expand wildcard
…ndows - OpenSSH Vulnerabilities CRM:0461061344 Description of vulnerability: https://www.bleepingcomputer.com/news/security/vulnerability-affects-all-openssh-versions-released-in-the-past-two-decades/ Merged relevant changes from original fix in OpenSSH main repo - openbsd/src@779974d Steps to validate fix: https://blog.nviso.be/2018/08/21/openssh-user-enumeration-vulnerability-a-close-look/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.