Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests for parse error DiagnosticMarkers #1872

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Add regression tests for parse error DiagnosticMarkers #1872

merged 2 commits into from
Aug 4, 2022

Conversation

fflaten
Copy link
Contributor

@fflaten fflaten commented Aug 4, 2022

PR Summary

Regression tests to verify diagnostic markers for parse errors are:

  • Registered on file open (first time)
  • Updated on file change
  • Not overwritten by AnalysisService (PSSA)

PR Context

No tests for this feature AFAIK.
Broke this momentarily while working on #1869

@fflaten fflaten requested a review from a team August 4, 2022 20:44
@fflaten
Copy link
Contributor Author

fflaten commented Aug 4, 2022

@andschwa Forgotten tests-debt paid with interest 🙂

andyleejordan
andyleejordan approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you so much 🥳

@andyleejordan andyleejordan enabled auto-merge (squash) August 4, 2022 21:40
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Aug 4, 2022
@andyleejordan andyleejordan merged commit 1d23697 into PowerShell:main Aug 4, 2022
@fflaten fflaten deleted the parseerrormarkers-tests branch August 4, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fflaten @andyleejordan