Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DoesNotDuplicateScriptMarkersAsync regression test #1870

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add DoesNotDuplicateScriptMarkersAsync regression test #1870

merged 1 commit into from
Aug 4, 2022

Conversation

andyleejordan
Copy link
Member

This is a regression test for #1869.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Aug 4, 2022
@andyleejordan andyleejordan requested a review from a team August 4, 2022 18:57
@andyleejordan
Copy link
Member Author

@fflaten Hey look, a regression test! 🫡

@andyleejordan andyleejordan mentioned this pull request Aug 4, 2022
Closed
SeeminglyScience
SeeminglyScience approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) August 4, 2022 19:00
@fflaten
Copy link
Contributor

fflaten commented Aug 4, 2022

Thanks! Didn't know where to start on that.

@andyleejordan andyleejordan merged commit 7853976 into main Aug 4, 2022
@andyleejordan andyleejordan deleted the andschwa/DoesNotDuplicateScriptMarkersAsync branch August 4, 2022 19:12
@andyleejordan
Copy link
Member Author

Thanks! Didn't know where to start on that.

No worries at all, I've been on a regression test roll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyleejordan @fflaten @SeeminglyScience