Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for debugging script with dot-source operator #1858

Merged
merged 5 commits into from
Jul 22, 2022

Conversation

andyleejordan
Copy link
Member

Covers regression in PowerShell/vscode-powershell#3715.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Jul 21, 2022
@andyleejordan andyleejordan requested a review from a team July 21, 2022 19:45
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan
Copy link
Member Author

Well this is odd. The introduction of this test has caused the others (which are supposedly isolated by Xunit) to fail. Grr. Will look at tomorrow.

@andyleejordan
Copy link
Member Author

I know what I did 😅

@andyleejordan andyleejordan force-pushed the andschwa/dotsource-test branch from e95fa43 to 402ab4f Compare July 22, 2022 15:51
This reverts commit 49500fa.

Something weird is going on with the Ubuntu CI where some of these tests
hang, needs more investigation.
@andyleejordan andyleejordan enabled auto-merge July 22, 2022 16:21
@andyleejordan andyleejordan merged commit 97de52b into main Jul 22, 2022
@andyleejordan andyleejordan deleted the andschwa/dotsource-test branch July 22, 2022 16:36
@andyleejordan andyleejordan mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants