Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for $PSDebugContext in prompt function #1857

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add regression test for $PSDebugContext in prompt function #1857

merged 2 commits into from
Jul 21, 2022

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Jul 20, 2022 •
edited
Loading

This covers the regression reported in PowerShell/vscode-powershell#3980 and fixed in #1803, part of #1733.

@andyleejordan andyleejordan requested a review from a team July 20, 2022 16:58
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Jul 20, 2022
@andyleejordan
Copy link
Member Author

Hey @jhoneill look, a regression test 😆

SeeminglyScience
SeeminglyScience approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 7252de6 into main Jul 21, 2022
@andyleejordan andyleejordan deleted the andschwa/test-psdebugcontext branch July 21, 2022 19:29
@andyleejordan andyleejordan mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience