Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IDE0005 (unneccessary using statements) as error #1759

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

andyleejordan
Copy link
Member

Due to a quirk in how msbuild runs rules, documentation generation
must be enabled for this rule (and presumably others) to be respected.

See dotnet/roslyn#22579.

Fixes #1479.

@ghost ghost added Area-General Issue-Enhancement A feature request (enhancement). labels Apr 18, 2022
@andyleejordan andyleejordan marked this pull request as draft April 18, 2022 17:57
@andyleejordan
Copy link
Member Author

Interesting...passed locally, looks like in other configs though I need to clean up some using statements! And disable a bunch of XML warnings I don't care about. Converted to draft.

@andyleejordan andyleejordan force-pushed the andschwa/fix-ide0005 branch 2 times, most recently from 5e991a4 to d664e81 Compare April 20, 2022 20:14
Due to a quirk in how `msbuild` runs rules, documentation generation
must be enabled for this rule (and presumably others) to be respected.
@andyleejordan andyleejordan marked this pull request as ready for review April 20, 2022 20:28
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) LGTM!

@andyleejordan andyleejordan enabled auto-merge April 20, 2022 20:38
@andyleejordan andyleejordan merged commit 24b5962 into master Apr 20, 2022
@andyleejordan andyleejordan deleted the andschwa/fix-ide0005 branch April 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-General Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-cleanup unused using statements
2 participants