Fix perf issue using WSMan provider or Get-PSSessionConfiguration #7680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
.NET Core introduced a perf regression during instantiation of ServiceController which is used by the WSMan Config Provider to check if WinRM is running as it depends on WinRM to get configuration information.
Instead of creating new instance of ServiceController every time we need to check WinRM service status. We can create it just once and use the
Refresh()
method on the instance to get latest status information. This brings the perf back to comparable to Windows PowerShell.Prior to this change, Windows PowerShell calling
Get-PSSessionConfiguration
took ~3 secs and PSCore6.1 took ~14 secs. After this change, PSCore6.1 took ~4 secs.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.[feature]
if the change is significant or affects feature tests