Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .Net Core/SDK docs about version 2.0 to be about version 2.x #7467

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

bergmeister
Copy link
Contributor

PR Summary

As per title. Due to the upgrade to .Net Core 2.1 in 6.1, it is better to not be specific about the version of .Net Core or the SDK.

PR Checklist

@TravisEz13
Copy link
Member

there are spelling failures in travis-ci

@bergmeister
Copy link
Contributor Author

@TravisEz13 I addressed the spelling issues.

@daxian-dbw daxian-dbw self-assigned this Aug 7, 2018
@@ -3,7 +3,7 @@
This guide supplements the [Linux instructions](./linux.md), as
building on macOS is almost identical.

.NET Core 2.0 (and by transitivity, us) only supports macOS 10.12+.
.NET Core 2.x (and by transitivity, us) only supports macOS 10.12+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the third bullet item also need to be changed?

Downloads and installs a preview version of .NET Core SDK 2.0 to ~/.dotnet

@@ -171,7 +171,7 @@ can't find the `netstandard.dll` "implementation" assembly for the version of th

### The fix for missing netstandard.dll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are stale references to 2.0 in this section. Two that stand out are

  • "Install the .NET Core SDK 2.0 for Windows, if it isn't already installed."
    This actually links to the .NET Core 2.1 page. Perhaps updating the link label to also use 2.x

  • Copy-Item 'C:\Program Files\dotnet\sdk\2.0.0\Microsoft...
    A note about the version number varying might help so users arent' blindly copy/pasting the text and getting errors.

@daxian-dbw
Copy link
Member

@dantraMSFT I pushed a commit to address your comments. Please take another look.

@daxian-dbw daxian-dbw merged commit b3c961f into PowerShell:master Aug 30, 2018
@TravisEz13 TravisEz13 added this to the v6.1.0 milestone Aug 31, 2018
@bergmeister
Copy link
Contributor Author

@daxian-dbw Thanks for helping out, I was quite busy the last weeks due to moving house and forgot about this PR.

@daxian-dbw
Copy link
Member

@bergmeister No worries, that's what we maintainers do 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants