Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup new OneBranch pipeline #2027

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Setup new OneBranch pipeline #2027

merged 5 commits into from
Sep 11, 2024

Conversation

andyleejordan
Copy link
Member

And some overdue clean-ups.

* Azure Pipelines
* Docker containers
* AppVeyor
* ESRP
* Slight .NET SDK bump to satisfy Component Governance
* Update license with OSPO's preferred format
* Add self to TSA notification list
* Remove containers VS Code extension suggestion
We should not be doing this for the developer/user.
@andyleejordan
Copy link
Member Author

Hey @bergmeister are you still using the Docker containers? I assumed not as they hadn't been updated in years.

@andyleejordan andyleejordan marked this pull request as ready for review September 11, 2024 17:41
Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!
this looks great to me

@andyleejordan andyleejordan merged commit f7304c7 into main Sep 11, 2024
7 checks passed
@andyleejordan andyleejordan deleted the test/onebranch branch September 11, 2024 22:49
@bergmeister
Copy link
Collaborator

Hey @bergmeister are you still using the Docker containers? I assumed not as they hadn't been updated in years.

@andyleejordan Sorry for the late reply. Yes, I find them very useful. The only thing that needs updating is the .NET version, which doesn't happen very often due to having support older PS versions. I've been busy generally but plan to look at new issues and pull requests again soon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyleejordan Although we are not running Appveyor in CI any more, I am still running it in my fork to check that PowerShell 4 build and test still works (hence why appveyor.psm1 was kept as well)

@@ -45,6 +49,13 @@ jobs:
if: matrix.os == 'windows-latest'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add another 'OS' in the matrix so that there is one windows run for powershell core and one for windows powershell so that it can finisher quicker.
What we've lost with this test approach is that the test job used to be its own job just consuming the binary as artefacts (and the repo checkout because of test files although they should've technically also been an artefact). This ensured that the built binaries were sufficient and weren't relying on something else left lying around from the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants