Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the correct example use the declared variable #1111

Merged
merged 5 commits into from
Jan 10, 2019
Merged

Make the correct example use the declared variable #1111

merged 5 commits into from
Jan 10, 2019

Conversation

Fonta
Copy link
Contributor

@Fonta Fonta commented Dec 15, 2018

PR Summary

Makes the example a little bit easier to understand.

PR Checklist

bergmeister
bergmeister reviewed Dec 15, 2018
View reviewed changes
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting the typo. I suggest to rather use $date, I'll change it to that

@Fonta
Copy link
Contributor Author

Fonta commented Dec 15, 2018

@bergmeister That's what i did too initially. Don't know why I changed it to use $t since I'm a big fan of using meaningfull variable names. Cheers.

@bergmeister bergmeister merged commit d0aa363 into PowerShell:development Jan 10, 2019
bergmeister pushed a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 5, 2019
@Fonta @bergmeister
Make the correct example use the declared variable (PowerShell#1111)
71ac6e5 
* Make the correct example use the declared variable

* Use $date

* fix whitespace
bergmeister pushed a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
@Fonta @bergmeister
Make the correct example use the declared variable (PowerShell#1111)
f8d2bc0 
* Make the correct example use the declared variable

* Use $date

* fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister bergmeister approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fonta @bergmeister