Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Update CommonResourceHelper and ResourceHelper tests to Pester 4 standards #132

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

PlagueHO
Copy link
Contributor

Pull Request (PR) description

This PR:

  • Update CommonResourceHelper unit tests to meet Pester 4.0.0
    standards (issue #129).
  • Update ResourceHelper unit tests to meet Pester 4.0.0
    standards (issue #129).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju would you mind reviewing when you get a moment. Should be straight forward.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jan 20, 2019
@johlju
Copy link
Contributor

johlju commented Jan 20, 2019

This is really strange. The Reviewable button points to the xPSDesiredStateConfiguraiton equivalent. 🤔

Copy link
Contributor

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment in GitHub review since Reviewable button points wrongly.

@codecov-io
Copy link

Codecov Report

Merging #132 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #132   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        19     19           
  Lines      2760   2760           
  Branches      4      4           
===================================
  Hits       2305   2305           
  Misses      451    451           
  Partials      4      4

@PlagueHO
Copy link
Contributor Author

Oh wow - that is pretty weird about the reviewable. I wonder if this is a long standing issue?

@PlagueHO PlagueHO merged commit 28b300c into PowerShell:dev Jan 20, 2019
@PlagueHO PlagueHO deleted the Issue-129 branch January 20, 2019 09:51
@johlju
Copy link
Contributor

johlju commented Jan 20, 2019

@PlagueHO First time I have seen it. Didn't see the Reviewable status check either, so probably a temporary glitch

@PlagueHO
Copy link
Contributor Author

Will keep an eye on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants