dnsdist: properly set protocol when logging

[chbruyand]

Short description

This PR properly sets protocol when logging via dnstap or protobuf when using DNS over QUIC and DNS over HTTP/3.

For protobuf, we add a httpVersion field so we can distinguish between DoH and DoHTTP/3 (PowerDNS/dnsmessage#8).
We should eventually do something similar for dnstap if there is a possibility to do so (dnstap/dnstap.pb#20).

Fix #13672 and #13673

Todo:

• add regression tests
• should I include the formatting commit ?

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[coveralls]

Pull Request Test Coverage Report for Build 7568813501

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 57.698%

---

Totals
Change from base Build 7545714324:	0.002%
Covered Lines:	107810
Relevant Lines:	155503

---

💛 - Coveralls

[rgacogne]

Nice!

[rgacogne]

* [ ]  should I include the formatting commit ?

If you can find the motivation to fix the clang-tidy warnings resulting from the reformat then yes, please :)

[rgacogne]

Thanks a lot for dealing with the massive pain of delinting these files! I think we need to discuss one clang-tidy rule with the team, so I'll bring it up on the internal chat.

[chbruyand]

Thanks a lot for dealing with the massive pain of delinting these files! I think we need to discuss one clang-tidy rule with the team, so I'll bring it up on the internal chat.

I reverted the const member related changes and the dnsname.{cc,hh} files.

Sorry I've gone a bit wild with clang-tidy.

[chbruyand]

There is still one clang-tidy warning left:

pdns/dnsdist-lua-actions.cc:945 narrowing conversion from 'std::vector::size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined (bugprone-narrowing-conversions)

This should be fixed with the modification made in:
#13723

The above fix might have some collateral damages, so I purpose to ignore that warning for the scope of this PR.