auth API: rectify after bumping serial, so the SOA record also gets rectified #12677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeha
reviewed
Mar 23, 2023
| @@ -826,6 +810,22 @@ static void updateDomainSettingsFromDocument(UeberBackend& B, const DomainInfo& | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Rectify | |||
There was a problem hiding this comment.
Suggested change
| // Rectify | |
| // Rectify after ALL RRset modifications are done (incl. SOA) |
There was a problem hiding this comment.
The proposed comment is confusing. Rectify is also triggered by non rrset changes here.
There was a problem hiding this comment.
good point, in fact my test case was changing nsec3param!
There was a problem hiding this comment.
Suggested change
| // Rectify | |
| // Rectify. This needs to happen after all (RRset and other) modification are done, incl. automatic RRs. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
I think the old behaviour is harmless, as other records (like the apex NSset) will fill out the NSEC3 chain nicely, but it's better to be entirely correct.
Needs a test. (to reproduce, do remember to set
SOA-EDIT-API.DEFAULTis good enough.)Checklist
I have: