Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for lacp cmdlets #45

Merged
merged 3 commits into from
Nov 25, 2018
Merged

Conversation

CedricMoreau
Copy link
Contributor

@CedricMoreau CedricMoreau commented Oct 22, 2018

Part of issue #36

Copy link
Collaborator

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename to LACP.Test.ps1 ?

Can you add some check status (using Get-ArubaSWPort ?)

Add also a second port on LACP ?

May be also enhance (after) VlanPorts and add some vlan to a LACP interface ?


../common.ps1

$mysecpassword = ConvertTo-SecureString $password -AsPlainText -Force
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to connect (it is already connect on common)


../common.ps1

$mysecpassword = ConvertTo-SecureString $password -AsPlainText -Force
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer need (include on common.ps1)

Copy link
Collaborator

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move on Tests\integration folder

and the test don't work for me

  [-] Error occurred in test script '..\..\PowerArubaSW\Public\LACP.Test.ps1' 7.79s
    ParameterBindingValidationException: Impossible de lier l'argument au paramètre « String », car il a la valeur Null.    à <ScriptBlock>, PowerArubaSW\PowerArubaSW\Public\LACP.Test.ps1 : ligne 10

@alagoutte alagoutte merged commit 787831d into PowerAruba:master Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants