Add Get|Set-ArubaSWPort #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Information like name/description, Configuration Mode (Speed..), status...
name/description, Mode Configuration, status...
|
@CedricMoreau can you look ? |
CedricMoreau
reviewed
Nov 2, 2018
PowerArubaSW/Public/Port.ps1
Outdated
| Get Port of the Switch | ||
|
|
||
| .DESCRIPTION | ||
| Get Portinformation |
There was a problem hiding this comment.
Add a space ? (Between port and informtion)
PowerArubaSW/Public/Port.ps1
Outdated
|
|
||
| <# | ||
| .SYNOPSIS | ||
| Get Port Sstatisticsof the Switch |
PowerArubaSW/Public/Port.ps1
Outdated
| Get Port Sstatisticsof the Switch | ||
|
|
||
| .DESCRIPTION | ||
| Get Portinformation |
| } else { | ||
| $_port | add-member -name "is_dsnoop_port_trusted" -membertype NoteProperty -Value $false | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a blank line maybe ?
| } | ||
| $response = invoke-ArubaSWWebRequest -method "PUT" -body $_port -url $url | ||
|
|
||
| $response | convertfrom-json |
| Set-ArubaSWPort -port_id 3 -name DEFAULT_PORT | ||
| #Always enable the port (disabled on WorkBench...) | ||
| Set-ArubaSWPort -port_id 3 -is_port_enable | ||
| } |
Tests/integration/Port.Tests.ps1
Outdated
| } | ||
|
|
||
| It "Get ALL Port" { | ||
| $PORTS = Get-ArubaSWPort |
There was a problem hiding this comment.
Indent ? (not the same as below )
| #TODO: Add check if no ipaddress/login/password info... | ||
|
|
||
| Describe "Get Port" { | ||
| BeforeAll { |
There was a problem hiding this comment.
Add a blank line (or remove it at line 43)
| $PORT.drop_tx | Should -Not -BeNullOrEmpty | ||
| $PORT.port_speed_mbps | Should -Not -BeNullOrEmpty | ||
| } | ||
| } |
Tests/integration/Port.Tests.ps1
Outdated
| } | ||
|
|
||
| It "Get ALL Port Stastistics" { | ||
| $PORTS = Get-ArubaSWPortStatistics |
2 new Get (Get-ArubaSWPort/Get-ArubaSWPortStatistics) and a Set (Set-ArubaSWPort) cmdlets
alagoutte
added a commit
to alagoutte/PowerArubaSW
that referenced
this pull request
Nov 25, 2018
3 new cmdlets * Enhance speed (Don't wait 5sec between each request...) (PowerAruba#32) * Enhance security (Enable TLS 1.2 when HTTPS is used...) (PowerAruba#60) * Better "error" message when fail to connect or use a API (PowerAruba#55) * Add -usebasicparsing for use without connnected session (like task) (PowerAruba#56) * Add integration test (using Pester) for check code (Known issue about VSF Switch) (PowerAruba#36) * Add Get|Set-ArubaSWPort(-statistics) to get and configure a port (name, status, mode...) and Port statistics (name, packets/bytes/throughtput/error TX or RX...) (PowerAruba#40) * Add [Extract-Port-ArubaSW.ps1 tools script](https://github.com/PowerAruba/PowerArubaSW/blob/master/Tools/Extract-Port-ArubaSW.ps1) for generate a Excel file with the list of Port and configuration (vlan, status, lldp neighbor...) (PowerAruba#34) * 4 removed cmdlets (Get-ArubaSWSystemStatus[Cpu|Memory|Storage|Time] (PowerAruba#43)
alagoutte
added a commit
to alagoutte/PowerArubaSW
that referenced
this pull request
Nov 26, 2018
3 new cmdlets * Enhance speed (Don't wait 5sec between each request...) (PowerAruba#32) * Enhance security (Enable TLS 1.2 when HTTPS is used...) (PowerAruba#60) * Better "error" message when fail to connect or use a API (PowerAruba#55) * Add -usebasicparsing for use without connnected session (like task) (PowerAruba#56) * Add integration test (using Pester) for check code (Known issue about VSF Switch) (PowerAruba#36) * Add Get|Set-ArubaSWPort(-statistics) to get and configure a port (name, status, mode...) and Port statistics (name, packets/bytes/throughtput/error TX or RX...) (PowerAruba#40) * Add [Extract-Port-ArubaSW.ps1 tools script](https://github.com/PowerAruba/PowerArubaSW/blob/master/Tools/Extract-Port-ArubaSW.ps1) for generate a Excel file with the list of Port and configuration (vlan, status, lldp neighbor...) (PowerAruba#34) * 4 removed cmdlets (Get-ArubaSWSystemStatus[Cpu|Memory|Storage|Time] (PowerAruba#43)
Merged
alagoutte
added a commit
that referenced
this pull request
Nov 26, 2018
3 new cmdlets * Enhance speed (Don't wait 5sec between each request...) (#32) * Enhance security (Enable TLS 1.2 when HTTPS is used...) (#60) * Better "error" message when fail to connect or use a API (#55) * Add -usebasicparsing for use without connnected session (like task) (#56) * Add integration test (using Pester) for check code (Known issue about VSF Switch) (#36) * Add Get|Set-ArubaSWPort(-statistics) to get and configure a port (name, status, mode...) and Port statistics (name, packets/bytes/throughtput/error TX or RX...) (#40) * Add [Extract-Port-ArubaSW.ps1 tools script](https://github.com/PowerAruba/PowerArubaSW/blob/master/Tools/Extract-Port-ArubaSW.ps1) for generate a Excel file with the list of Port and configuration (vlan, status, lldp neighbor...) (#34) * 4 removed cmdlets (Get-ArubaSWSystemStatus[Cpu|Memory|Storage|Time] (#43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmdlets for Get and Configure Port (name, config, status, flow control, dsnoop trust...)