Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RADIUS GROUP Function #108

Merged
merged 19 commits into from
Nov 14, 2021
Merged

Add RADIUS GROUP Function #108

merged 19 commits into from
Nov 14, 2021

Conversation

CedricMoreau
Copy link
Contributor

No description provided.

alagoutte
alagoutte requested changes Oct 11, 2019
View reviewed changes
Copy link
Collaborator

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good but missing test for Get-ArubaSWRadiusGroup and Remove-ArubaSWRadiusGroup

alagoutte
alagoutte requested changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good need some minor change before merge

PowerArubaSW/Public/RADIUS_GROUP.ps1 Outdated Show resolved Hide resolved
Tests/integration/RADIUS_GROUP.Tests.ps1 Outdated Show resolved Hide resolved
@alagoutte alagoutte added this to the v0.9.0 milestone Nov 2, 2019
@alagoutte alagoutte force-pushed the RADIUS_GROUP_Function branch from daa10d3 to 07fa222 Compare January 2, 2020 16:48
@alagoutte alagoutte force-pushed the RADIUS_GROUP_Function branch from 07fa222 to 42696b8 Compare November 12, 2021 12:06
Cédric Moreau and others added 18 commits November 14, 2021 16:47
@alagoutte
Add RADIUS GROUP Function
de34b2d
@alagoutte
Complete the tests
1b379cd
@alagoutte
Fix minor issues on code
c593c9f
@alagoutte
Fix typo
8756208
@alagoutte
RADIUSServerGroup: fix indent (using Visual Code Formatter)
7cd28a4
@alagoutte
RADIUSServerGroup: fix test (*-ArubaSWRadius => *-ArubaSWRadiusServer)
279590c
@alagoutte
RADIUSServerGroup(Tests): use [Before|After]All for Get-ArubaSWRadius…
57da16b 
…Group tests
@alagoutte
RADIUSServerGroup: ipaddressX => ServerX
a429421
@alagoutte
RADIUSServerGroup(Tests): fix remove RADIUS Server
f3bc19b
@alagoutte
RADIUSServerGroup: Add [Before|After]All for Remove Tests
c067372
@alagoutte
RADIUSServerGroup: Use ipaddress type for server parameter (Add-Aruba…
90b2888 
…SWRadiusGroup
@alagoutte
RADIUSServerGroup: Rename RADIUSGroup => RADIUSServerGroup
2a2e602
@alagoutte
RADIUSServerGroup: Fix SYNOPSIS and DESCRIPTION
bdf3c51
@alagoutte
RADIUSServerGroup: Enhance EXAMPLE
05cec05
@alagoutte
RADIUSServerGroup: Add pipeline support for Remove-ArubaServerGroup
741617c
@alagoutte
RADIUSServerGroup(Tests): Remove unneeded ArubaSWRADIUSServer (Alread…
5f33d61 
…y remove on AfterEach)
@alagoutte
RADIUSServerGroup: fix .EXAMPLE for Remove-ArubaSWRadiusServerGroup
4256122
@alagoutte
RADIUSServerGroup: Use better Describe/Context description
9e0f8e2
@alagoutte alagoutte force-pushed the RADIUS_GROUP_Function branch from 42696b8 to 9e0f8e2 Compare November 14, 2021 15:47
@alagoutte alagoutte merged commit 8d01cb5 into PowerAruba:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alagoutte alagoutte alagoutte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CedricMoreau @alagoutte