Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMetadata for directory does not return directory metadata #6

Closed
spwilson806 opened this issue Dec 14, 2015 · 7 comments
Closed

getMetadata for directory does not return directory metadata #6

spwilson806 opened this issue Dec 14, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@spwilson806
Copy link
Contributor

When calling getMetadata on a directory entity, it seems to return a multidimensional array of metadata for the entities of that directory, not the metadata for the directory itself. This seems to be inconsistent with the other native flysystem adapters that I have worked with.

@Potherca
Copy link
Owner

Thank you for reporting this issue.

This behaviour does indeed seem incorrect and not in line with expected behaviour. I am marking this as a bug.

This behaviour exists because the response from the underlying library that this adapter uses is passed on ad verbatim.

Looking at the Github API docs on this subject, it states:

Response if content is a directory

The response will be an array of objects, one object for each item in the directory.

Do you have timeframe for how soon you need/want this to be fixed?

@Potherca Potherca added the bug label Dec 14, 2015
@Potherca Potherca self-assigned this Dec 14, 2015
@spwilson806
Copy link
Contributor Author

Not a huge hurry. I think I was hoping to use this in something that I would start demoing sometime in January. I'm also happy to jump in and help as needed.

@spwilson806
Copy link
Contributor Author

Just checking in to see if you had any more thoughts here or had some sort of timeframe. Thanks!

@Potherca
Copy link
Owner

Thanks for the bump!

I had planned to do some work on this right after the holidays but unfortunately things didn't go as planned.

I am currently in the process of looking for a new job for after my current contract ends. Any work I get to do on this project beforehand is a bonus but in all likelihood it'll have to wait until after I've landed a new contract.

@Potherca
Copy link
Owner

Potherca commented Apr 4, 2016

New contract is all but signed, so time for an update!

Work on this issue is underway. I've fixed the original issue but I've found some other discrepancies that I would also like to fix. Most of these are done in the linked pull-request.

The last thing that is needed before I can merge the changes and create a new release is refactor the unit-tests for the Api class. They have become too convoluted/complex (specifically in regards to mocks). Once that is done and all tests are green again, all is done.

@spwilson806
Copy link
Contributor Author

Awesome. This looks great. I noticed one other issue while I was testing. I'll go see if it's still present after the update and put in another issue if it's still around. Thanks!

@Potherca Potherca modified the milestone: v0.3.0 Apr 5, 2016
Potherca added a commit that referenced this issue Apr 19, 2016
@Potherca
Copy link
Owner

Fixed by 6374601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants