New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow error handling in replayer #3

Open

pauldambra wants to merge 1 commit into master from feat/allow-error-handling-in-replayer

Member

pauldambra commented Jan 19, 2024

opening a pr just against our internal one for now

this is the PR version of the error handling we've patched into production

is it yucky? that the tests access private members - maybe but I don't want to change too much just yet

this PR adds

optional onError config to playerConfig so existing codebases don't have to suddenly provide one
defaults that to throwing - the existing behaviour - when constructing a player
wraps incremental mutation application with an error handler that calls that handler instead of throwing if it is present


          feat: allow error handling in replayer

f453291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet