Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Improve experience of restricted insights #9467

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 20, 2022

Problem

Addresses #8460 (comment) (not the whole issue, just that comment).

Changes

Three commits, three changes:

  1. Don't show redundant lock icon on insight description – one lock, on the insight name aka page title, is enough
  2. Allow playing with insight settings in view mode (read-only) – this is the main issue
  3. Show lock icon in dashboards list – previously it wasn't possible to tell if you can edit a dashboard just looking at the list

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pauldambra pauldambra merged commit cfb3b52 into master Apr 21, 2022
@pauldambra pauldambra deleted the better-restricted-insight-experienced branch April 21, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants