Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): Improve insight refresh button experience #9018

Merged
merged 4 commits into from
Mar 14, 2022
Merged

fix(insights): Improve insight refresh button experience #9018

merged 4 commits into from
Mar 14, 2022

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Mar 14, 2022

Problem

Resolves #7284.

Changes

This improves the experience of this UI:

Screen Shot 2022-03-14 at 17 11 13

  • If the minimum refresh interval is 3 minutes, the component will now allow refreshing as soon as it shows "3 minutes ago" (it was a bit out of sync before)
  • There's now a common hook for periodic rerendering of components (usePeriodicRerender)
  • Fixed computation time being hidden for saved insights by using loadInsight result for lastRefresh

How did you test this code?

Manual testing by refreshing insights.

@Twixes Twixes requested a review from mariusandra March 14, 2022 16:14
@mariusandra mariusandra merged commit fec52bb into master Mar 14, 2022
@mariusandra mariusandra deleted the periodic-rerender branch March 14, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insight refresh disabled state is misleading
2 participants
@Twixes @mariusandra