Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(correlation): use api.get to fetch people #7024

Closed
wants to merge 18 commits into from
Closed

fix(correlation): use api.get to fetch people #7024

wants to merge 18 commits into from

Conversation

hazzadous
Copy link
Contributor

In the previous pr I'd accidentially not committed this change. For
consistency I updated to use api.get instead of fetch

Harry Waye added 18 commits November 9, 2021 13:56
feat(correlation): use people_url to load people modal
ddd7e4e 
This change adds a new method to the `personsModelLogic` to allow for
specifying a url to be used to retrieve people from. I've avoided
overloading the existing `loadPeople` and rather added a new one,
`lostPeopleFromUrl`.

Currenlty this is only being used by correlations, but the intention is
to extend it's usage to anywhere else that is performing drilldowns to
people from, for instance, the trends aggregation.
add paycard back
7b8b553
make labels look right
2566d06
remove unused code
6b77e69
fix typing in test
f8921e1
fix typing in personsModelLogic
204e5a6
refactor to make eventUsageLogic work
e4ff935
fix typing
a07ade0
fix typing again
69b30fa
Merge remote-tracking branch 'origin/master' into gh-6953-frontend
97532e2
remove some funnel stories
510185a
get storybook working with paycard
61c3dd2
cleaned up the interface a little
a00a2a4
Merge remote-tracking branch 'origin/master' into gh-6953-frontend
28b4367
chore(correlation): use api.get for fetching people
f8edd37 
This updates to use api.get, and also converts the returned uri from the
correlation endpoint to an absolut uri, instead of just an absolute
path.

The `api.get` method expects either an abolute uri, or a relative path.
I'd rather not use an relative path as it's not obvious what it should
be relative to.
fix tests
9163b27
make storybook uris absolute
c7d62d7
fix(correlation): use api.get to fetch people
ee99202 
In the previous pr I'd accidentially not committed this change. For
consistency I updated to use api.get instead of fetch
@hazzadous
Copy link
Contributor Author

@EDsCODE did this in one of his PRs

@hazzadous hazzadous closed this Nov 15, 2021
yakkomajuri added a commit that referenced this pull request Dec 13, 2021
@yakkomajuri
Add special migrations to instance status (#7024 pt. 7) (#7565)
33c09ff 
* add special migration definition and example

* types

* special migrations runner

* fix tests

* fix tests 2

* add clickhouse runner

* add temp fix for tests

* wip

* add special migrations api (#7448)

* wip new structure

* update example sourcing

* Update .gitignore

* yet another wip structure

* code quality

* cypress

* test docker image build

* implement resumable ops

* code quality

* add comments

* add warning

* add conditional requirements for migration

* add comment on is_required

* add dependency map

* wip dependencies and run migration on startup

* code quality

* fix bugs

* fix more bugs

* format

* types

* remove api from this branch

* types

* types

* update clickhouse script

* add is_migration_in_range util

* fix type

* Add special migrations API

* fix api

* update api with new columns

* fix runner

* add AUTO_START_SPECIAL_MIGRATIONS env var

* reset migration on start

* Special migrations UI (#7054 pt. 6) (#7493)

* update UI with new cols

* fix UI

* new UI statuses

* cleanup

* wip per op rollback

* add refresh button

* wip tests

* prevent accidental status rollback

* finish api tests

* Update bin/tests

* add utils and definition test

* update example with rollback per op

* wip test special migration

* add first runner tests

* add runner tests

* add util for code paths

* fix test

* fix types

* fix types again

* cleanup

* cleanup

* add periodic healthcheck task tests

* remove unused imports

* safer row updates

* fix coalescing none checks

* code quality

* add handling for non-staff users

* Add special migrations to instance status

* add docstrings

* fix

* fix deploys issue

* update scripts

* add delay

* address reviews

* address review comments

* address review comments

* address final comments

* fix import error

* fix tests

* remove unused imports

* fix tests

* fix task test

* remove unused return value

* remove unused special migrations code from migrate_clickhouse

* tweaks to support fresh deployments

* make instance first user staff

* fix import
paolodamico pushed a commit that referenced this pull request Dec 15, 2021
@yakkomajuri @paolodamico
Add special migrations to instance status (#7024 pt. 7) (#7565)
986c05c 
* add special migration definition and example

* types

* special migrations runner

* fix tests

* fix tests 2

* add clickhouse runner

* add temp fix for tests

* wip

* add special migrations api (#7448)

* wip new structure

* update example sourcing

* Update .gitignore

* yet another wip structure

* code quality

* cypress

* test docker image build

* implement resumable ops

* code quality

* add comments

* add warning

* add conditional requirements for migration

* add comment on is_required

* add dependency map

* wip dependencies and run migration on startup

* code quality

* fix bugs

* fix more bugs

* format

* types

* remove api from this branch

* types

* types

* update clickhouse script

* add is_migration_in_range util

* fix type

* Add special migrations API

* fix api

* update api with new columns

* fix runner

* add AUTO_START_SPECIAL_MIGRATIONS env var

* reset migration on start

* Special migrations UI (#7054 pt. 6) (#7493)

* update UI with new cols

* fix UI

* new UI statuses

* cleanup

* wip per op rollback

* add refresh button

* wip tests

* prevent accidental status rollback

* finish api tests

* Update bin/tests

* add utils and definition test

* update example with rollback per op

* wip test special migration

* add first runner tests

* add runner tests

* add util for code paths

* fix test

* fix types

* fix types again

* cleanup

* cleanup

* add periodic healthcheck task tests

* remove unused imports

* safer row updates

* fix coalescing none checks

* code quality

* add handling for non-staff users

* Add special migrations to instance status

* add docstrings

* fix

* fix deploys issue

* update scripts

* add delay

* address reviews

* address review comments

* address review comments

* address final comments

* fix import error

* fix tests

* remove unused imports

* fix tests

* fix task test

* remove unused return value

* remove unused special migrations code from migrate_clickhouse

* tweaks to support fresh deployments

* make instance first user staff

* fix import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hazzadous