Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more Sentry logging to configure_scope #6343

Merged
merged 2 commits into from
Oct 9, 2021
Merged

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Oct 8, 2021

Changes

Sentry was being used as push_scope. That only sets data on scope within that python block

Configure_scope sets data for the entire django request

see #4816

How did you test this code?

unit tests and running locally

@timgl timgl temporarily deployed to posthog-pr-6343 October 8, 2021 21:53 Inactive
@pauldambra pauldambra merged commit e47ddf3 into master Oct 9, 2021
@pauldambra pauldambra deleted the sentry-scope branch October 9, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants