Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags request origins in Sentry when loading request data from the body #6287

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

pauldambra
Copy link
Member

Changes

adds the request origin to sentry messages when loading data from the body

allows categorisation of errors in sentry by origin

How did you test this code?

added unit test for the behaviour

@timgl timgl temporarily deployed to posthog-pr-6287 October 6, 2021 14:22 Inactive
@timgl timgl temporarily deployed to posthog-pr-6287 October 6, 2021 15:16 Inactive
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@27f9481). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6287   +/-   ##
=========================================
  Coverage          ?   91.77%           
=========================================
  Files             ?      393           
  Lines             ?    29951           
  Branches          ?     2584           
=========================================
  Hits              ?    27488           
  Misses            ?     1931           
  Partials          ?      532           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f9481...910cb24. Read the comment docs.

@pauldambra pauldambra requested a review from mariusandra October 7, 2021 08:22
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag all the hosts!

@pauldambra pauldambra force-pushed the tag-origin-in-sentry branch from 910cb24 to 62eff41 Compare October 7, 2021 11:46
@timgl timgl temporarily deployed to posthog-pr-6287 October 7, 2021 11:47 Inactive
@pauldambra pauldambra enabled auto-merge (squash) October 7, 2021 11:48
@pauldambra pauldambra merged commit 275139c into master Oct 7, 2021
@pauldambra pauldambra deleted the tag-origin-in-sentry branch October 7, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants