-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flags in toolbar frontend #5866
Conversation
738d746
to
75ddde6
Compare
This is ready for review. A couple of notes:
feature-flag-override-demo.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing!
I have just two comments regarding the nemesis of all macOS frontend developers: scrollbars 🤣 .
I actually recommend everyone working in frontend enable this setting to always catch them:
The problem is all Windows computers always show scrollbars, so it'll look really ugly for those users... and we must prevent that.
- The scrollbar here is also slightly off. Could it be at the very right of the window?
Changes
The front-end work to allow users to override their feature flags from the toolbar.
Dependent on #5824
feature-flag-demo.mov
Remaining items todo:
Checklist