-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path end point target #5746
Path end point target #5746
Conversation
, if(start_index > 0, arraySlice(timings, start_index), timings) as filtered_timings | ||
, arraySlice(filtered_path, 1, %(event_in_session_limit)s) as limited_path | ||
, arraySlice(filtered_timings, 1, %(event_in_session_limit)s) as limited_timings | ||
, indexOf(compact_path, %(target_point)s) as target_index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even without a funnel path pinning, I think we should allow having both start and end points?
So, thoughts on making this a two step thing? First filter for start point, then for end point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we limit start and end, that's equivalent to funnel path pinning right? I was going to implement that differently using your new query, unless i'm thinking about the functionalities incorrectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost equivalent, just the timestamp boundaries & person joins are missing.
but yeah, no issues, if you have a different way in mind, go for it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it a bit more, this sounds like two separate features to me:
(1) On a general Paths view, limit start and end points. (and this can also have Cohort filters, so you're limiting start and end points for a specific set of people)
(2) Find Paths for specific people at specific points in time (a.k.a funnel path pinning). This looks the same as (1), since we have start and end points, but this is different from (1) since our timeframe for each person is different (unlike the Cohort): we care about the user at a point in the funnel, and where they go from there.
(2) definitely makes sense, and (1) sounds great for Paths exploration apart from funnels. (we already did start points)
I think we should build both.
cc: @paolodamico , @marcushyett-ph @clarkus for product input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this makes more sense. Originally I had a notion that they were different and then I forgot because I was only thinking about the start and end point. thanks for the clarification
Changes
Please describe.
If this affects the frontend, include screenshots.
Checklist