-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funnel persons path #5699
Funnel persons path #5699
Conversation
], | ||
} | ||
funnel_filter = Filter(data=data) | ||
path_filter = PathFilter(data=data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is, I think, another sign of "We should have a single filter object that works".
Although, I think your call is right here. I'd also like to finish basic Paths first, before thinking of this refactor :)
@@ -1,5 +1,5 @@ | |||
FUNNEL_PERSONS_BY_STEP_SQL = """ | |||
SELECT person_id | |||
SELECT person_id {timestamp} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should be extra_fields
?
Can also wait till we actually have other fields, like when we get to path pinning.
Changes
Please describe.
funnel_paths
funnel_paths: True
, the path data returned will be base don the funnel dropoffIf this affects the frontend, include screenshots.
Checklist