Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel persons path #5699

Merged
merged 7 commits into from
Aug 25, 2021
Merged

Funnel persons path #5699

merged 7 commits into from
Aug 25, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Aug 23, 2021

Changes

Please describe.

  • Adds field funnel_paths
  • when paths endpoint is called with the funnel parameters in question along with funnel_paths: True, the path data returned will be base don the funnel dropoff
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5699 August 23, 2021 20:36 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5699 August 23, 2021 22:45 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5699 August 24, 2021 01:33 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5699 August 24, 2021 14:46 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5699 August 24, 2021 16:49 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review August 24, 2021 16:50
@EDsCODE EDsCODE temporarily deployed to posthog-pr-5699 August 24, 2021 17:35 Inactive
@EDsCODE EDsCODE requested a review from neilkakkar August 25, 2021 00:50
],
}
funnel_filter = Filter(data=data)
path_filter = PathFilter(data=data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, I think, another sign of "We should have a single filter object that works".

Although, I think your call is right here. I'd also like to finish basic Paths first, before thinking of this refactor :)

@@ -1,5 +1,5 @@
FUNNEL_PERSONS_BY_STEP_SQL = """
SELECT person_id
SELECT person_id {timestamp}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be extra_fields ?

Can also wait till we actually have other fields, like when we get to path pinning.

@neilkakkar neilkakkar merged commit bf51de1 into master Aug 25, 2021
@neilkakkar neilkakkar deleted the funnel-persons-path branch August 25, 2021 11:02
@EDsCODE EDsCODE mentioned this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants