Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel improvements - Graph type, identical steps, UI updates #5384

Merged
merged 8 commits into from
Aug 2, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Jul 30, 2021

Changes

This PR implements a few improvements to funnels and insights in general:

  1. We now show information about duplicate and sequential steps (closes Explain how identical funnel steps work in the UI #5088)

  1. Filters & breakdown are now split into a separate card following the mockups for this.

  2. The "Add filter", "Add breakdown" & "Add formula" buttons across all insights are now links instead of a default button.

  1. We implement a brand new graph type selector that looks good even on narrow screens (closes Improve funnels graph type selector #5235).

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5384 July 30, 2021 03:53 Inactive
@timgl timgl temporarily deployed to posthog-pr-5384 July 30, 2021 22:00 Inactive
@paolodamico
Copy link
Contributor Author

@clarkus one thing I'm not sure about is how the new link type button displays in certain contexts, see below (spacing looks strange), wdyt?

@paolodamico paolodamico marked this pull request as ready for review July 30, 2021 22:18
@timgl timgl temporarily deployed to posthog-pr-5384 July 30, 2021 22:18 Inactive
@clarkus
Copy link
Contributor

clarkus commented Jul 30, 2021

These changes look good to me. Regarding the link placement, in this type of layout, I generally try to align with the input value. It's like that link has the same box properties as the form above it, just without color values.
Screen Shot 2021-07-30 at 3 20 54 PM

@paolodamico
Copy link
Contributor Author

@alexkim205 could you help me out with a code review and maybe just address this aligning improvement? I'm swamped in other issues right now

@alexkim205
Copy link
Contributor

alexkim205 commented Aug 2, 2021

  • Added an arrow to mimic our property filter nesting in other insight graphs
  • Aligned 'Add new filter' to text

CC @clarkus @paolodamico

Screen Shot 2021-08-02 at 10 59 29 AM

@timgl timgl temporarily deployed to posthog-pr-5384 August 2, 2021 18:02 Inactive
@paolodamico paolodamico enabled auto-merge (squash) August 2, 2021 18:40
@timgl timgl temporarily deployed to posthog-pr-5384 August 2, 2021 18:40 Inactive
@paolodamico paolodamico merged commit a30d3e9 into master Aug 2, 2021
@paolodamico paolodamico deleted the funnel-improvements-IX branch August 2, 2021 18:57
@alexkim205 alexkim205 mentioned this pull request Aug 3, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve funnels graph type selector Explain how identical funnel steps work in the UI
4 participants