-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funnel improvements - Graph type, identical steps, UI updates #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@clarkus one thing I'm not sure about is how the new link type button displays in certain contexts, see below (spacing looks strange), wdyt? |
clarkus
approved these changes
Jul 30, 2021
@alexkim205 could you help me out with a code review and maybe just address this aligning improvement? I'm swamped in other issues right now |
alexkim205
reviewed
Aug 2, 2021
frontend/src/scenes/insights/InsightTabs/FunnelTab/FunnelSecondaryTabs.tsx
Outdated
Show resolved
Hide resolved
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements a few improvements to funnels and insights in general:
Filters & breakdown are now split into a separate card following the mockups for this.
The "Add filter", "Add breakdown" & "Add formula" buttons across all insights are now links instead of a default button.
Checklist