Insights short share URL #4513
Merged
Insights short share URL #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolodamico
force-pushed
the
saved-reports-I
branch
from
1fc10fa to
3df6c81
Compare
|
Ready for a review, not sure why tests are failing, they pass locally. Seems like the issue with webpack (related thread), see screenshot of failed tests.
|
EDsCODE
reviewed
May 28, 2021
|
Merging this,
|
macobo
reviewed
Jun 1, 2021
| def create_short_ids(apps, schema_editor): | ||
| DashboardItem = apps.get_model("posthog", "DashboardItem") | ||
| for obj in DashboardItem.objects.all(): | ||
| obj.short_id = posthog.models.dashboard_item.generate_short_id() |
There was a problem hiding this comment.
This will likely cause users to be unable to update in the future if we ever rename the method in the model
Rather than relying on app code in a migration it's smarter to inline the code, even if it means duplication.
paolodamico
added a commit
that referenced
this pull request
Jun 1, 2021
This reverts commit 1b0240d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR sets some groundwork for saved reports & facilitating collaboration with insights (#3408).
short_id(~8 alpha character) so saved insights can be shared easily (think like a YT video)./i/{id}, making it easy to share them with other team members (e.g.https://app.posthog.com/i/DXQRFh3F.Checklist