-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk invite team members (setup section II) #3143
Merged
+588
−83
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e1e087f
bulk invite team members base UI
paolodamico 37708b4
bulk invite controlled form
paolodamico 94aaa60
show which field haves an error
paolodamico 43df91d
OrganizationInvite serializer cleanup
paolodamico 911a999
tmp: invitedTeamMembers
paolodamico 66fbc5a
fix ts
paolodamico d549323
bulk create invites part I
paolodamico 49c3c6e
add first_name to OrganizationInvites + update tests
paolodamico aa7ab47
fixes security bug
paolodamico 27c42c1
updates tests & permissions
paolodamico f01b800
negative test cases
paolodamico 09e513a
fix typing
paolodamico c392a68
more fixes
paolodamico 15084f8
actual invite creation
paolodamico e48425a
fix ee tests
paolodamico 3d81d3c
permissions cleanup
paolodamico f0cfa5a
more permission optimizations + add some missing tests
paolodamico d03d020
fix typing
paolodamico a931f95
Make PLACEHOLDER_NAMES nicer
Twixes 2f8b405
Fix OrganizationInviteBulkViewSet route ID
Twixes 82845fb
Fix code quality errs
Twixes e097813
latest migration update
paolodamico f8826ea
address feedback
paolodamico bbfe224
simplify code
paolodamico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add first_name to OrganizationInvites + update tests
commit 49c3c6e080bc728ba276a3583bfe0943618108bf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 3.0.11 on 2021-02-01 15:09 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("posthog", "0121_organization_setup_section_2_completed"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="organizationinvite", | ||
name="first_name", | ||
field=models.CharField(blank=True, default="", max_length=30), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field name is
first_name
, but is this actually intended for first name explicitly? If this is only a holdover fromUser.first_name
(which is kind of a legacy issue), then it should probably be justname
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it is indeed to match
User.first_name
, but I thought we were just using first name, not full name everywhere else too (e.g. the signup form says first name and the placeholder says "Jane"). Sofirst_name
sounds appropriate even then, thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm pretty sure we're using full names, just using a single field, as we don't use
User.last_name
anywhere. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, actually we are kind of using it… accidentally, as social auth fills it in on registration. We should get this straight either way. Thoughts @paolodamico?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I'm not sure what most users did before we revamped the signup page, but for recent users not doing social auth, I think it's pretty straightforward to just type your first name. I would just do first name everywhere, it has easier backwards support, it's nicer to receive emails addressed like "Hey John! instead of "Hey John Doe!" and I don't think we really need the last name for anything.
The only reason I can think for this is for very large teams, but in that case maybe the email address is enough, or they could just do full name by their own decision?