Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths background color in dashboard #3089

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix paths background color in dashboard #3089

merged 2 commits into from
Jan 27, 2021

Conversation

yakkomajuri
Copy link
Contributor

@yakkomajuri yakkomajuri commented Jan 26, 2021 •
edited
Loading

Changes

Please describe.
If this affects the frontend, include screenshots.

Closes #3019

Listen to changes to the color prop passed to dashboard items via Element and react accordingly.

Before

Screenshot 2021-01-26 at 16 02 56

After

Screenshot 2021-01-26 at 16 02 47

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@yakkomajuri yakkomajuri requested a review from EDsCODE January 26, 2021 16:05
@timgl timgl temporarily deployed to posthog-paths-bg-swkznznspzdjx January 26, 2021 16:07 Inactive
Twixes
Twixes reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely more aesthetic, but also hardly readable at all, so I'm on the fence…

@yakkomajuri
Copy link
Contributor Author

@Twixes happy to play with the colors - would you want the text to be more white maybe?

@timgl timgl temporarily deployed to posthog-paths-bg-swkznznspzdjx January 27, 2021 11:22 Inactive
@yakkomajuri
Copy link
Contributor Author

New look

Screenshot 2021-01-27 at 11 21 20

@Twixes
Copy link
Member

Twixes commented Jan 27, 2021

The blue on blue is still pretty bad accessibility-wise, but looks much nicer than what we have now, so let's go ahead with this

@Twixes Twixes merged commit 7dc40f2 into master Jan 27, 2021
@Twixes Twixes deleted the paths-bg branch January 27, 2021 14:56
@paolodamico paolodamico mentioned this pull request Jan 28, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes left review comments

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paths panel background color doesn't fully update
3 participants
@yakkomajuri @Twixes @timgl