Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Community tag to plugins #2982

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add Community tag to plugins #2982

merged 1 commit into from
Jan 19, 2021

Conversation

yakkomajuri
Copy link
Contributor

Changes

Please describe.
If this affects the frontend, include screenshots.

I guess this conflicts with #2965 but just bringing this up because it's important to differentiate core team vs community plugins here too so users are aware of what they're installing and we can be more liberal with accepting community plugins into the list.

Style is consistent with the website plugin library.

Screenshot 2021-01-18 at 12 26 26

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-add-plugin-comm-azzc75 January 18, 2021 15:35 Inactive
@mariusandra mariusandra merged commit f39877f into master Jan 19, 2021
@mariusandra mariusandra deleted the add-plugin-community-tag branch January 19, 2021 10:11
@mariusandra mariusandra mentioned this pull request Jan 19, 2021
4 tasks
@paolodamico
Copy link
Contributor

Some post-facto feedback on this, if it leads somewhere I can move it to an issue.

Please push back, but not a big fan of doing "Core Team" as this a) either gives me a vibe of a hobby project or b) is something that only an engineer that's familiar with OSS terminology will understand. I think it'd be better to do something that conveys an "official" vibe. Keeping it standardized maybe we could try something like we do for PostHog properties? Or maybe it's just as simple matter as changing the label.

Screenshot 2021-01-19 at 5 51 25 PM

Probably out of scope for this PR, but should there be a third category, something like community but verified?

CC @mariusandra, @yakkomajuri just some thoughts

@mariusandra
Copy link
Collaborator

Why not "Official" vs "Community"?

@paolodamico
Copy link
Contributor

Think that works well for now 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants