Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round sessions value #2925

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Round sessions value #2925

merged 6 commits into from
Jan 21, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 12, 2021

Changes

Please describe.

  • scale sessions value when possible
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@EDsCODE EDsCODE mentioned this pull request Jan 12, 2021
Closed
21 tasks
@timgl timgl temporarily deployed to posthog-round-sessions--au0qai January 12, 2021 21:49 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-round-sessions--au0qai January 12, 2021 22:25 Inactive
Twixes
Twixes reviewed Jan 12, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty cool, just took a preliminary glance

posthog/queries/sessions.py Outdated Show resolved Hide resolved
posthog/queries/sessions.py Outdated Show resolved Hide resolved
posthog/api/insight.py Outdated Show resolved Hide resolved
@EDsCODE EDsCODE temporarily deployed to posthog-round-sessions--au0qai January 12, 2021 23:28 Inactive
@EDsCODE EDsCODE requested a review from timgl January 14, 2021 21:24
Twixes
Twixes approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EDsCODE EDsCODE merged commit 97f0cbd into master Jan 21, 2021
@EDsCODE EDsCODE deleted the round-sessions-value branch January 21, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @Twixes @timgl