Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REST hook deletion #2893

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix REST hook deletion #2893

merged 3 commits into from
Jan 8, 2021

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jan 8, 2021

Changes

This is a fix for REST hook deletion.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests

@Twixes Twixes requested a review from mariusandra January 8, 2021 11:14
@Twixes Twixes changed the title Fix rest hook delete Fix REST hook deletion Jan 8, 2021
@timgl timgl temporarily deployed to posthog-fix-rest-hook-d-gd0lrq January 8, 2021 11:16 Inactive
mariusandra
mariusandra approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty hard for me to E2E test... though the code looks fine. So LGTM!

@Twixes Twixes merged commit 43b0972 into master Jan 8, 2021
@Twixes Twixes deleted the fix-rest-hook-delete branch January 8, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Twixes @mariusandra @timgl