feat: delete capture events in reverse proxy

[surbhi-posthog]

Problem

Adding a capture event with a reverse proxy is deleted.

Sorry for the small changes but I've been battling with testing these logs locally. Once I can verify them locally, I will push larger changes for the remaining team features.

Changes

Verified managed reverse proxy's can be created and deleted in the frontend

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Cloud: yes

How did you test this code?

Locally by adding and deleting managed reverse proxies

[patricio-posthog]

It looks good to me. Just a minor comment: we are capturing intent here, right? Because the actual action/work runs async, so we don't know if it was succesful or not. Maybe you want to make that explicit in the event? Like managed reverse proxy intent created or something like that? (that sounds better in English haha)

[surbhi-posthog]

@zlwaterfield @patricio-posthog, i think it would be better to call the capture in a try block to make sure we only capture success events. If they fail, we should capture failed events separately in my opinion. Let me know what you guys think?

[patricio-posthog]

@zlwaterfield @patricio-posthog, i think it would be better to call the capture in a try block to make sure we only capture success events. If they fail, we should capture failed events separately in my opinion. Let me know what you guys think?

Since this is async you can't do that. You should move the capture code into the async task, since this try/except only checks if the task was dispatched but not the outcome.

[zlwaterfield]

@patricio-posthog - I'm not sure what you mean, this is the record creation so it should be fine as is. We could have another one when the record is verified in the DNS.

@surbhi-posthog - We shouldn't need the try/catch, this is how events are captured throughout the codebase, it's using the PostHog SDK and should be fine.

[patricio-posthog]

@zlwaterfield Yeah I thought we want to send the capture event once the whole process was succesful (creation + verification), but if it's enough only with the creation then it's fine.