fix: Specify multidict version on requirements
#26602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't install our dependencies on Ubuntu 24 because of this broken version. The problem was fixed in a later patch version, let's just move it there, there aren't any other relevant changes that would block this.
rafaeelaudibert
added
the
dependencies
rafaeelaudibert
commented
Dec 3, 2024
Comment on lines
+270
to
+271
| greenlet==3.1.1 | ||
| # via sqlalchemy |
There was a problem hiding this comment.
I think this is changing because someone forgot to call uv compile after changing the requirements recently
Twixes
reviewed
Dec 3, 2024
requirements-dev.in
Outdated
| @@ -23,6 +23,7 @@ Faker==17.5.0 | |||
| fakeredis[lua]==2.23.3 | |||
| freezegun==1.2.2 | |||
| inline-snapshot==0.12.* | |||
| multidict==6.0.5 | |||
There was a problem hiding this comment.
Since we don't import multidict anywhere, let's explicitly comment on this requirement's line why it's needed
There was a problem hiding this comment.
That makes sense, just added the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't install our dependencies on Ubuntu 24 because of a broken Ubuntu wheel. The problem was fixed in a later patch version, let's just move it there, there aren't any other relevant changes that would block this.